Fix linting: finish the conversion to v9 and flat configs, make lint not silently fail and fix a bunch of type errors #3932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
I realized lint runs were going too fast...when I realized it was silently hiding errors. This led to the realization that the switch to v9 and the new flat config went a bit too easily. So this has a series of fixes of note.
After that it was fixing a number of linting issues:
Verification
This should be an eng-sys + typing change so builds are the main validation mechanism.